Forums | MacLife

Are you using PHP5 with mysqli?
If so, I have a suggestion.

Bummer, you're on PHP4 so my trick won't work.
It is a simple operation and your code looks right, but you should be doing it all in the same connection, something like this:

<?php
    $database = "jasoco_table1";
    $dbx = mysql_connect("localhost","******","*****");
    @mysql_select_db($database) or die( "Unable to select database");
    
    // get current value
    $query="SELECT * FROM options WHERE options.name='home_count'";
    $result=mysql_query($query);
    $count=mysql_result($result,'0',"value");
    
    // update and insert
    $count++;
    $query = "UPDATE options SET options.value = '".$count."' WHERE name = 'home_count'";
    mysql_query($query);

    mysql_close();    
?>

Then, later in the page:

<p>Hit count: <?php echo $count; ?></p>

I suspect the problem with your page is that you could be incrementing the hit_count twice in the page?

At least like this you get two benefits:
1. all your sql happens on the same connection
2. you select, increment and save right away

Try to do all your SQL on the same connection - if you want, you can open the connection at the top of the page, close it at the bottom, and then use mysql_free_result() in between queries. If you're opening and closing connections throughout the page you're putting undue stress on the server by increasing both memory allocation and db server connections...

If you're using includes and that is why you're opening and closing so much, then consider gathering all mysql data first thing and then declaring the variables in the global scope, its may feel dirty, but it's not too bad.

Indeed.

SELECT value FROM options WHERE name='home_count' LIMIT 1;

Would be better.

Last edited by Daniel (2007-09-28 6:52 am)

I do it for readability.

Alien wrote:

select * is bad form.

Just sayin'.

,xtG
.tsooJ

Well, in his defense, with such a small data set its probably not any kind of extra burden.

Pulling 10000 rows would be a little different.

Yeah, it's PHP 4. I don't know why FourBucks hasn't updated. They still offer WordPress 1.5 when the official version is up to 2.0+.

I gotta contact them. See what's so behind.